nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

fix breadcrumbs to the top of learn page

Open dtsuper3 opened this issue 10 months ago • 4 comments

Fixes #6651

Description

I have relocated the breadcrumbs to the top section.

Validation

Related Issues

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [ ] I have run npx turbo build to check if the website builds without errors.
  • [ ] I've covered new added functionality with unit tests if necessary.

dtsuper3 avatar Apr 14 '24 09:04 dtsuper3

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 14, 2024 9:56am

vercel[bot] avatar Apr 14 '24 09:04 vercel[bot]

I wouldn't create PRs for things that haven't been decided yet. There's a high chance this won't get merged at all.

ovflowd avatar Apr 14 '24 09:04 ovflowd

@ovflowd Could you please check again? I forgot to include the link to the open issue.

dtsuper3 avatar Apr 14 '24 10:04 dtsuper3

@ovflowd Could you please check again? I forgot to include the link to the open issue.

I'm not sure what you mean by this comment. The issue you're referring to is a discussion that had 0 replies yet. This means we won't proceed with your PR before the Website team reaches a consensus.

In other words, I'm just advising you that the time you've spent on this PR might be in vain, as this PR is not guaranteed to get merged... At all. 😅

ovflowd avatar Apr 14 '24 10:04 ovflowd