nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: move update-v8-5.4.md to announcements folder

Open reeveng opened this issue 1 year ago • 2 comments

Description

This approach assumes the category was right and it was placed in the wrong folder. The other approach that could fix the issue is switching out the category in the frontmatter, but think this is the right approach.

Validation

Assumed and validated that the path is depended on the location within the folder structure (blog pages in the blog/ folder at least).

Related Issues

Fixes #6641

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

reeveng avatar Apr 10 '24 23:04 reeveng

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 10, 2024 11:53pm

vercel[bot] avatar Apr 10 '24 23:04 vercel[bot]

To fix this in the future, I could also add a "test" that fails the husky precommit, would basically check whether the directory corresponds to the category in the frontmatter.

reeveng avatar Apr 11 '24 00:04 reeveng

The problem is not the file name. And it MUST not be changed. This should come from the withSidebarCrossLinks component.

Never changed the file name, just the files location. Besides, 2 people working on the same thing doesn't make sense. So since the other PR is more active, the other guy can take it over, not here to waste either of ours time.

reeveng avatar Apr 11 '24 16:04 reeveng