nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: numerous fixes regarding package manager page

Open ovflowd opened this issue 1 year ago • 3 comments

Description

This PR does a few fixes/changes as discussed on previous issues and as pointed out:

  • Remove the installation of the said package managers on the CodeBox snippets (except NVM, which is "universal" and specific to Node).js)
    • The reasoning is that folks will know how to install (and/or must have these package managers) preinstalled, such as Docker, Homebrew, and Chocolatey, as they are "OS" package managers, not Node.js package managers.
  • Add Docker option for Linux since we removed Docker installation instructions
  • Added warning that folks need to ensure that package managers are installed
  • Fixed height of the CodeBox section
  • Fixed bug that you couldn't switch between OSs (we were being too restrictive with one of the dropdowns)
  • Fixed Choco LTS package

Validation

  • Ensure functionality on the Package Manager tab is working as expected

Related Issues

Fixes https://github.com/nodejs/nodejs.org/issues/6637 Fixes https://github.com/nodejs/nodejs.org/issues/6479

ovflowd avatar Apr 10 '24 11:04 ovflowd

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Apr 10, 2024 11:03am

vercel[bot] avatar Apr 10 '24 11:04 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

github-actions[bot] avatar Apr 10 '24 12:04 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.09% (582/646) 76.1% (172/226) 91.4% (117/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 5.683s :stopwatch:

github-actions[bot] avatar Apr 10 '24 12:04 github-actions[bot]