nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

chore: Add serbian language config

Open beny996 opened this issue 1 year ago • 7 comments

Description

Added Serbian localization to the i18n/config.json.

Validation

Related Issues

No related issues

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

beny996 avatar Apr 09 '24 09:04 beny996

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 1:09pm

vercel[bot] avatar Apr 09 '24 09:04 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

github-actions[bot] avatar Jun 15 '24 13:06 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 5.363s :stopwatch:

github-actions[bot] avatar Jun 15 '24 13:06 github-actions[bot]

@beny996 We need more information here.

Is this Cyrillic or Latin?

image

I suspect we might need to update https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L15-L20

bmuenzenmeyer avatar Jun 15 '24 13:06 bmuenzenmeyer

@bmuenzenmeyer It is latin. Sorry for the delay.

beny996 avatar Jul 01 '24 08:07 beny996

Serbian (latin) added in crowdin

bmuenzenmeyer avatar Jul 01 '24 18:07 bmuenzenmeyer

This PR will need to be rebased or recreated now that https://github.com/nodejs/nodejs.org/pull/6850 merged.

bmuenzenmeyer avatar Jul 05 '24 11:07 bmuenzenmeyer

I will recreate the PR. @bmuenzenmeyer

beny996 avatar Jul 12 '24 09:07 beny996