nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: Changelog trigger and minor visual bugs

Open canerakdas opened this issue 1 year ago • 3 comments

Description

This PR aims to solve some minor visual problems on mobile and the SEO problem in the change log trigger.

  • The anchor element in the changelog trigger has been removed, and @radix-ui/react-slot has been added, which we can use in such cases.
  • Fixed the overflow issue in the changelog modal
  • Underline styling in headings in mobile resolution has been removed
  • The semibold font arrangement was made instead of the underlined links we added for accessibility in mobile design. IMO we do not lose anything in accessibility and the content looks more focused.

Validation

Badge Component

image image

Headings

image image

Changelog modal

image image

In Preview we need to make sure everything is working correctly on mobile/desktop and our SEO scores are improving

Related Issues

Fixes #6566

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

canerakdas avatar Mar 27 '24 08:03 canerakdas

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 27, 2024 8:55am

vercel[bot] avatar Mar 27 '24 08:03 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 96 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 98 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟢 100 🟢 92 🔗

github-actions[bot] avatar Mar 27 '24 09:03 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 83%
79.33% (453/571) 76.06% (143/188) 69.91% (79/113)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 :zzz: 0 :x: 0 :fire: 4.545s :stopwatch:

github-actions[bot] avatar Mar 27 '24 09:03 github-actions[bot]

Awesome stuff, @canerakdas!!! Thank you so much!

ovflowd avatar Mar 28 '24 23:03 ovflowd