nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

added Urdu language config

Open thisalihassan opened this issue 1 year ago • 5 comments

Description

Adds Urdu language setup to config.json to enable Urdu translations on Crowdin

Validation

Related Issues

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

thisalihassan avatar Mar 26 '24 16:03 thisalihassan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jul 8, 2024 1:22pm

vercel[bot] avatar Mar 26 '24 16:03 vercel[bot]

Hi, can I have a follow up on this?

thisalihassan avatar Apr 11 '24 23:04 thisalihassan

Hi, can I have a follow up on this?

We are not merging any related i18n PR until we get our Crowdin integration fixed. Sorry for the waiting.

ovflowd avatar Apr 12 '24 06:04 ovflowd

we need more information here

image

I suspect we might need to also update https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L15-L20

bmuenzenmeyer avatar Jun 15 '24 13:06 bmuenzenmeyer

This PR will need to be rebased or recreated now that https://github.com/nodejs/nodejs.org/pull/6850 merged.

bmuenzenmeyer avatar Jul 05 '24 11:07 bmuenzenmeyer

we need more information here

image

I suspect we might need to also update https://github.com/nodejs/nodejs.org/blob/main/crowdin.yml#L15-L20

"ur-IN" is not officially recognized in the same way as "ur-PK" in many internationalization standards. Urdu as spoken in Pakistan and India is fundamentally the same in terms of syntax and grammar

cc: @bmuenzenmeyer

thisalihassan avatar Jul 07 '24 23:07 thisalihassan

ur-PK added in Crowdin

bmuenzenmeyer avatar Jul 08 '24 12:07 bmuenzenmeyer

ur code is not officially supported by Crowdin, so it was added as a custom language to the project: https://crowdin.com/project/nodejs-web/ur

Now you can see expected code I hope!

Andrulko avatar Jul 08 '24 13:07 Andrulko

Unit Test Coverage Report

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 5.312s :stopwatch:

github-actions[bot] avatar Jul 08 '24 13:07 github-actions[bot]