nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: progression sidebar active color

Open sijan2 opened this issue 1 year ago • 3 comments

Description

Changed the active color of navbar items in the "Learn" section of the docs for better contrast and clarity. The previous color made it difficult to determine the selected navbar item.

Validation

ProgressionSideBarItem_active_color

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

sijan2 avatar Mar 25 '24 21:03 sijan2

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 27, 2024 1:58am

vercel[bot] avatar Mar 25 '24 21:03 vercel[bot]

Hey there 🧇 I'm only worried about the contrast of those colours. I actually think instead of changing the colour you should make the text bold. That would actually be way better IMO

ovflowd avatar Mar 26 '24 10:03 ovflowd

+1 for Claudio proposal

AugustinMauroy avatar Mar 26 '24 10:03 AugustinMauroy