nodejs.org
nodejs.org copied to clipboard
nodejs
feat(tabs): fix contrast ratio
Description
To solve issue I had follow Figma design. And allow forcing dark theme to allow codeTabs to force theme.
Validation
Related Issues
Fixe #6527
Check List
- [X] I have read the Contributing Guidelines and made commit messages that follow the guideline.
- [X] I have run
npx turbo formatto ensure the code follows the style guide. - [X] I have run
npx turbo testto check if all tests are passing. - [X] I have run
npx turbo buildto check if the website builds without errors. - NA I've covered new added functionality with unit tests if necessary.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| nodejs-org | ✅ Ready (Inspect) | Visit Preview | Mar 28, 2024 9:17am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Lighthouse Results
| URL | Performance | Accessibility | Best Practices | SEO | Report |
|---|---|---|---|---|---|
| /en | 🟢 99 | 🟢 90 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about | 🟢 98 | 🟢 91 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about/previous-releases | 🟢 99 | 🟢 90 | 🟢 100 | 🟢 92 | 🔗 |
| /en/download | 🟢 99 | 🟠 89 | 🟢 96 | 🟢 91 | 🔗 |
| /en/blog | 🟢 100 | 🟢 90 | 🟢 100 | 🟢 92 | 🔗 |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unit Test Coverage Report
| Lines | Statements | Branches | Functions |
|---|---|---|---|
 |
80.1% (451/563) | 79.44% (143/180) | 71.17% (79/111) |
Unit Test Report
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 90 | 0 :zzz: | 0 :x: | 0 :fire: | 4.436s :stopwatch: |
Screenshots of before/after pls?
yep _note there are no change on dark mode and on tabs comment _