nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

chore(i18n): add Mongolian locale in config

Open zolbooo opened this issue 1 year ago • 3 comments

Hi there! 👋

Description

Added Mongolian (mn) locale in i18n config.

Validation

Git diff shows changes in i18n/config.json

Related Issues

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npx turbo format to ensure the code follows the style guide.
  • [x] I have run npx turbo test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

zolbooo avatar Mar 25 '24 04:03 zolbooo

The latest updates on your projects. Learn more about Vercel for Git ↗

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 15, 2024 11:52am

vercel[bot] avatar Mar 25 '24 04:03 vercel[bot]

Hey guys, is it possible to get this PR merged anytime soon?

zolbooo avatar May 01 '24 11:05 zolbooo

Unfortunately not. Because crowdin has an MDX parsing problem, the whole translation process is blocked until a solution is found.

AugustinMauroy avatar May 01 '24 18:05 AugustinMauroy

Unfortunately not. Because crowdin has an MDX parsing problem, the whole translation process is blocked until a solution is found.

Just curiuos, where is this parsing issue occuring, are there any docs on a planned fix, I'd love to see where the magic is happening :-)

avivkeller avatar May 30 '24 00:05 avivkeller

Unfortunately not. Because crowdin has an MDX parsing problem, the whole translation process is blocked until a solution is found.

Just curiuos, where is this parsing issue occuring, are there any docs on a planned fix, I'd love to see where the magic is happening :-)

The parsing happens on the Crowdin platform. The issue is that their current MDX parser doesn't support correctly (or doesn't preserve) existing styles/formatting rules. So there's no much to see as it "happens behind the scenes"

We are already in contact with Crowdin and they are working on a solution. I asked them yesterday for an update and they are on the final stages of releasing the fix, which is awesome!

Appreciate the ping, Ive forgot to update folks on the matter in a while 😄

ovflowd avatar May 30 '24 00:05 ovflowd

Great! Thanks for the info!

avivkeller avatar May 30 '24 00:05 avivkeller

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟠 89 🟢 100 🟢 96 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 96 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

github-actions[bot] avatar Jun 15 '24 04:06 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 :zzz: 0 :x: 0 :fire: 5.128s :stopwatch:

github-actions[bot] avatar Jun 15 '24 04:06 github-actions[bot]

added in crowdin

bmuenzenmeyer avatar Jun 15 '24 12:06 bmuenzenmeyer