fix: Maximum scale and initial scale
Description
Since the initial-scale and maximum-scale are 1, our accessibility score drops to 94
https://dequeuniversity.com/rules/axe/4.8/meta-viewport
If we want to disable the scale/zoom at an input focus, we can consider disabling it before the input focus and then turning it on again. By default, this value should not remain the same
Validation
We need to make sure that there is no Lighthouse error below in the Vercel preview;
Check List
- [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
- [x] I have run
npx turbo formatto ensure the code follows the style guide. - [x] I have run
npx turbo testto check if all tests are passing. - [x] I have run
npx turbo buildto check if the website builds without errors. - [x] I've covered new added functionality with unit tests if necessary.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated (UTC) |
|---|---|---|---|
| nodejs-org | ✅ Ready (Inspect) | Visit Preview | Mar 24, 2024 2:01pm |
Lighthouse Results
| URL | Performance | Accessibility | Best Practices | SEO | Report |
|---|---|---|---|---|---|
| /en | 🟢 98 | 🟢 96 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about | 🟢 99 | 🟢 96 | 🟢 100 | 🟢 91 | 🔗 |
| /en/about/previous-releases | 🟢 99 | 🟢 95 | 🟢 100 | 🟢 92 | 🔗 |
| /en/download | 🟢 100 | 🟢 95 | 🟢 100 | 🟢 91 | 🔗 |
| /en/blog | 🟢 98 | 🟢 96 | 🟢 100 | 🟢 92 | 🔗 |
Unit Test Coverage Report
| Lines | Statements | Branches | Functions |
|---|---|---|---|
| 80.1% (451/563) | 79.44% (143/180) | 71.17% (79/111) |
Unit Test Report
| Tests | Skipped | Failures | Errors | Time |
|---|---|---|---|---|
| 90 | 0 :zzz: | 0 :x: | 0 :fire: | 4.591s :stopwatch: |
So this PR fixes the zoom issue or? 🤔
So this PR fixes the zoom issue or? 🤔
Yes, this PR makes the page zoomable. If you are using an iPhone, you will see that you can already zoom in, this is because it ignores this feature after iOS 10