Use stream/promises on home

[Joabesv]

Description

Remove promisify to use the pipeline from node:stream/promises

Validation

Related Issues

Check List

• [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
• [x] I have run npx turbo format to ensure the code follows the style guide.
• [x] I have run npx turbo test to check if all tests are passing.
• [x] I have run npx turbo build to check if the website builds without errors.
• [ ] I've covered new added functionality with unit tests if necessary.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Mar 24, 2024 0:11am

[github-actions[bot]]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 85	🟢 90	🟢 100	🟢 91	🔗
/en/about	🟢 99	🟢 91	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 98	🟢 90	🟢 100	🟢 92	🔗
/en/download	🟢 100	🟠 89	🟢 100	🟢 91	🔗
/en/blog	🟢 100	🟢 90	🟢 100	🟢 92	🔗

[github-actions[bot]]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	80.07% (450/562)	79.55% (144/181)	71.17% (79/111)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
90	0 :zzz:	0 :x:	0 :fire:	4.43s :stopwatch:

[Joabesv]

@ovflowd i can do it, just adding an extra space before the comment line. Will make the change and wait for feedback.

[lmammino]

I have already seen a few conversations with folks wondering why do we suggest to manually promisify pipeline rather than using the already promisified one in stream/promises.

I'd say, it would be nice to ship this one ASAP :)

Refs:

• https://twitter.com/maksimsinik/status/1771639350914167106
• https://www.linkedin.com/feed/update/urn:li:activity:7177282688326750208?commentUrn=urn%3Ali%3Acomment%3A%28activity%3A7177282688326750208%2C7177488964210053120%29&dashCommentUrn=urn%3Ali%3Afsd_comment%3A%287177488964210053120%2Curn%3Ali%3Aactivity%3A7177282688326750208%29

[lmammino]

Made a PR to, hopefully, help speeding things up a little :)

Let me know if it's easy to review/merge: https://github.com/Joabesv/nodejs.org/pull/1/

[ovflowd]

I checked your PR and it is not even opened against this repository + it has unrelated changes, I believe you did something wrong during the rebase.

[ovflowd]

I'd recommend just making a fresh new branch based out of main and applying the changes from this PR

[lmammino]

It's possible I did something wrong, since I also rebased off of current main. I didn't do a fresh PR because I didn't want to take over all the changes and take all the credit.

I believe that if @Joabesv merges that PR, this PR would be updated correctly.... Or at least that was my original intent 😅

But at this point I suspect it's probably easier/safer for @joabesv to do the changes by himself

[ovflowd]

I did the changes myself directly here, and I'm merging asap.

[lmammino]

Thanks @ovflowd 🙏😊