nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Redesign suggests all versions of Node.js include corepack

Open richardlau opened this issue 2 years ago • 7 comments

URL:

https://nodejs-org-git-meta-remove-legacy-website-code-openjs.vercel.app/en/download

Browser Name:

Firefox

Browser Version:

115.8.0

Operating System:

Windows 11

How to reproduce the issue:

In the redesign it looks like the download page unconditionally includes the string "and corepack": https://github.com/nodejs/nodejs.org/blob/0e15186fde66f5972357f427c7e5bffb213c2c69/pages/en/download/package-manager/current.mdx#L14

This means the string is always present, even if you select a really old version of Node.js e.g. v8.17.0.

AFAIK there is currently no quick way of determining if an arbitrary release of Node.js includes corepack short of looking at the source for the version or unpacking one of the archives. Corepack is not indexed in index.json/index.tab and is unlikely to be while it is experimental.

richardlau avatar Mar 05 '24 12:03 richardlau

image

richardlau avatar Mar 05 '24 12:03 richardlau

There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

AugustinMauroy avatar Mar 05 '24 12:03 AugustinMauroy

There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc

ovflowd avatar Mar 05 '24 12:03 ovflowd

There are a ways to know which version of Corepack is ship or not ship with nodejs ? Like for npm version.

Apparently not. @richardlau, when was Corepack introduced? We can make an if statement to not render this to versions it is known for not being supported. Or should we remove the mention from corepack in the meanwhile until the TSC has an agreement on whether we should or should not have it there? Cc @nodejs/tsc

According to the links from https://github.com/nodejs/node/pull/39608 16.9.0 and 14.9.0. It's not available in any version of Node.js 13.x and below. I'd prefer not to mention it until its future is decided. The pre-redesign website doesn't mention it.

richardlau avatar Mar 05 '24 12:03 richardlau

I'd prefer not to mention it until its future is decided

Thats my preference as well.

mhdawson avatar Mar 08 '24 17:03 mhdawson

cc @nodejs/nodejs-website feel free to make a PR (or @ruyadorno) cc @nodejs/tsc for awareness.

ovflowd avatar Mar 08 '24 19:03 ovflowd

Sorry I was OOO this week and I could not follow up with the conversation on #6396. @ovflowd feel free to either reopen that PR or open a new one please. 😊

ruyadorno avatar Mar 08 '24 23:03 ruyadorno

I've removed the Corepack mention for the time being, until the TSC decides the future of Corepack.

ovflowd avatar Apr 02 '24 09:04 ovflowd