nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

chore(content): remove `hbs` from layout metadata

Open AugustinMauroy opened this issue 1 year ago • 2 comments

Description

Remove legacy .hbs because it dates back to the time when the site was built with metalsmith.

Validation

All page should render correctly

Related Issues

No related Issues

Check List

  • [X] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [X] I have run npx turbo format to ensure the code follows the style guide.
  • [X] I have run npx turbo test to check if all tests are passing.
  • [X] I have run npx turbo build to check if the website builds without errors.
  • NA I've covered new added functionality with unit tests if necessary.

AugustinMauroy avatar Mar 04 '24 14:03 AugustinMauroy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 4, 2024 2:38pm

vercel[bot] avatar Mar 04 '24 14:03 vercel[bot]

[!NOTE]
Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. We recommend giving a read on our Translation Guidelines.

Thank you!

github-actions[bot] avatar Mar 04 '24 14:03 github-actions[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 92 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 99 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟢 100 🟢 92 🔗

github-actions[bot] avatar Mar 05 '24 10:03 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 :zzz: 0 :x: 0 :fire: 4.448s :stopwatch:

github-actions[bot] avatar Mar 05 '24 10:03 github-actions[bot]

I'm fast-tracking this as it is a "simple" change even tho it affects 1.3k files

ovflowd avatar Mar 05 '24 10:03 ovflowd