nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

chore(branding): introduce branding page

Open AugustinMauroy opened this issue 1 year ago • 1 comments

Description

Adding logo page call "branding" but I didn't add Design system.

Related Issues

Close #5545

Check List

  • [X] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [X] I have run npx turbo format to ensure the code follows the style guide.
  • [X] I have run npx turbo test to check if all tests are passing.
  • [X] I have run npx turbo build to check if the website builds without errors.
  • NA I've covered new added functionality with unit tests if necessary.

AugustinMauroy avatar Mar 04 '24 14:03 AugustinMauroy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 8, 2024 8:09pm

vercel[bot] avatar Mar 04 '24 14:03 vercel[bot]

image

Can you use a table here, instead of one logo per line?

ovflowd avatar Mar 05 '24 10:03 ovflowd

image

I'd remove this

ovflowd avatar Mar 05 '24 10:03 ovflowd

Can you use a table here, instead of one logo per line?

and what do you thinks about using flex and wrap for line return ?

AugustinMauroy avatar Mar 05 '24 12:03 AugustinMauroy

Can you use a table here, instead of one logo per line?

and what do you thinks about using flex and wrap for line return ?

Let's make a table with three two columns and two rows:

  • dark image | light image
  • link to asset | link to asset

ovflowd avatar Mar 05 '24 12:03 ovflowd

After you fix @mikeesto requests, all good!

FYI He proposed changes to the text that we removed the one about nodejs website design system. So there are nothing to do.

AugustinMauroy avatar Mar 05 '24 15:03 AugustinMauroy

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 90 🟢 100 🟢 92 🔗

github-actions[bot] avatar Mar 05 '24 15:03 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 84%
80.03% (449/561) 79.55% (144/181) 71.17% (79/111)

Unit Test Report

Tests Skipped Failures Errors Time
90 0 :zzz: 0 :x: 0 :fire: 4.433s :stopwatch:

github-actions[bot] avatar Mar 05 '24 15:03 github-actions[bot]