nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

Navigation Panel Issue

Open Nyaughh opened this issue 11 months ago • 2 comments

https://github.com/nodejs/nodejs.org/assets/110736557/3a18d5bc-5cf2-41f6-b5e6-3ed2cae35b26

When you click on the navigation bar, it increases the size of the page (I'm using Brave here but it's the same for chrome too)

Nyaughh avatar Mar 03 '24 12:03 Nyaughh

Hey @Nyaughh what's your screen size? i tried it on my phone(1080px × 2280px) it works fine. and doesn't zoom in when i open the menu

mwelwankuta avatar Mar 03 '24 18:03 mwelwankuta

Hey @Nyaughh what's your screen size? i tried it on my phone(1080px × 2280px) it works fine. and doesn't zoom in when i open the menu

Almost the same as yours, 1080×2400

Nyaughh avatar Mar 03 '24 18:03 Nyaughh

i was unable to replicate this issue, in chrome, brave, desktop with your exact screen dimentions? anyone else having the same issue ?

mwelwankuta avatar Mar 05 '24 05:03 mwelwankuta

https://github.com/nodejs/nodejs.org/blob/5380385e456f718648d9be3b8e2a69e0deb31224/next.dynamic.constants.mjs#L93

We should probably add maximumScale: 1 here I was able to replicate this on a pixel 3

manishprivet avatar Mar 05 '24 06:03 manishprivet

https://github.com/nodejs/nodejs.org/blob/5380385e456f718648d9be3b8e2a69e0deb31224/next.dynamic.constants.mjs#L93

We should probably add maximumScale: 1 here I was able to replicate this on a pixel 3

Feel free to make a PR

ovflowd avatar Mar 05 '24 10:03 ovflowd

Sorry about the accidental close

manishprivet avatar Mar 06 '24 06:03 manishprivet

https://github.com/nodejs/nodejs.org/blob/5380385e456f718648d9be3b8e2a69e0deb31224/next.dynamic.constants.mjs#L93

We should probably add maximumScale: 1 here I was able to replicate this on a pixel 3

thanks @manishprivet i tried it on a pixel 4 but looked fine. thanks for the pr. learnt something new today 😊

mwelwankuta avatar Mar 06 '24 09:03 mwelwankuta