nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard
verified publisher icon nodejs

Version dropdown on download page doesn't scroll on overflow

Open jenewland1999 opened this issue 2 years ago • 3 comments

URL:

https://beta-node-js-org.vercel.app/en/download

Browser Name:

Chrome

Browser Version:

122.0.6261.94

Operating System:

macOS 14.3.1

How to reproduce the issue:

  1. Went to the new beta Node.js website's download page https://beta-node-js-org.vercel.app/en/download
  2. Clicked the version dropdown (also known as a combobox or select)
  3. Expected it to be scrollable if the complete list cannot be shown within the visible viewport
  4. Instead, the overflow is hidden and thus means I cannot see the full list unless I zoom out.
image

jenewland1999 avatar Mar 02 '24 20:03 jenewland1999

That's odd! There should be a maximum height. I assume that is doable with https://www.radix-ui.com/primitives/docs/components/select following the docs of the component we use.

ovflowd avatar Mar 03 '24 00:03 ovflowd

Hello, I would like to work on this issue.

Thanks and Regards, Mohit Kambli

MohitKambli avatar Mar 03 '24 07:03 MohitKambli

Hello, Hope you're doing well. I have implemented the possible code changes and raised a PR for the same. If at all there are any changes required from my end, then do let me know. Sincere apologies if I made any mistakes while implementing the code changes or raising a PR for the same. Hope the code changes help in meeting the requirement.

Thanks and Regards, Mohit Kambli

MohitKambli avatar Mar 03 '24 08:03 MohitKambli