nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

chore(i18n): remove legacy key + rename

Open AugustinMauroy opened this issue 2 years ago • 5 comments

Description

Remove all legacy i18n key before re-enable Crowdin.

Related Issues

No related issues.

Check List

  • [X] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [X] I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • [X] I have run npx turbo format to ensure the code follows the style guide.
  • [X] I have run npx turbo test to check if all tests are passing.
  • [X] I've covered new added functionality with unit tests if necessary.

AugustinMauroy avatar Mar 02 '24 08:03 AugustinMauroy

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2024 11:08am

vercel[bot] avatar Mar 02 '24 08:03 vercel[bot]

LGTM! Looks good to me :)

ovflowd avatar Mar 02 '24 15:03 ovflowd

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 98 🟢 92 🟢 91 🔗
/en/about 🟢 100 🟢 98 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 91 🔗
/en/blog 🟢 100 🟢 96 🟠 83 🟢 92 🔗

github-actions[bot] avatar Mar 02 '24 15:03 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 :zzz: 0 :x: 0 :fire: 4.452s :stopwatch:

github-actions[bot] avatar Mar 02 '24 15:03 github-actions[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report /en 🔴 65 🟢 98 🟢 92 🟢 91 🔗 /en/about 🟢 100 🟢 98 🟢 92 🟢 92 🔗 /en/about/previous-releases 🟢 100 🟢 96 🟢 92 🟢 92 🔗 /en/download 🟢 100 🟢 97 🟢 92 🟢 91 🔗 /en/blog 🟢 98 🟢 96 🟠 83 🟢 92 🔗

I wonder why Lighthouse results got so bad? Let me rerun.

ovflowd avatar Mar 02 '24 15:03 ovflowd