nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Redesign updates

Open PickleNik opened this issue 11 months ago • 8 comments

before

https://github.com/nodejs/nodejs.org/assets/31113245/9d07d5d8-a54a-4b35-9584-023be183d568

after

https://github.com/nodejs/nodejs.org/assets/31113245/77daec13-e878-4f65-aa0b-ae2bb6b9ebda

PickleNik avatar Feb 29 '24 16:02 PickleNik

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 0:32am

vercel[bot] avatar Feb 29 '24 16:02 vercel[bot]

A rebase is needed here to make the build pass 👀

ovflowd avatar Feb 29 '24 16:02 ovflowd

I'm having trouble seeing what you're trying to solve. But if it's the hover effect on the header. I think you should use the same hover effect as in the footer. It would look better because the green hover is a bit aggressive.

AugustinMauroy avatar Feb 29 '24 16:02 AugustinMauroy

in general, how do we go about deciding if this, or any future change, is adherent to our design vision?

bmuenzenmeyer avatar Feb 29 '24 18:02 bmuenzenmeyer

Rebased, I made it green with transparency to match the hue of what active navlink background color is. But I can change it to what the footer does. Another idea I had is to just make them underline on hover.

PickleNik avatar Feb 29 '24 21:02 PickleNik

another thing to note, it's the same effect (grey button) as on the buttons for language, theme, rss feed (on the blog page)

AugustinMauroy avatar Mar 01 '24 08:03 AugustinMauroy

To be honest, I don't think we need a hover effect on the Navigation. I would say at max, just change the text colour to either darker or lighter and ensure they look good on both themes

ovflowd avatar Mar 01 '24 11:03 ovflowd

I like the idea of playing with the color of the text. It's simple, but it shows that the element is interactive.

AugustinMauroy avatar Mar 01 '24 15:03 AugustinMauroy

It looks like the author abandoned the PR.

ovflowd avatar Mar 19 '24 15:03 ovflowd

yeah my bad, I'll open a new one in spare time

PickleNik avatar Mar 19 '24 22:03 PickleNik

No worries! Appreciate the forthcoming!

ovflowd avatar Mar 19 '24 23:03 ovflowd