nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

NodeJS LTS Linux download link dead

Open theo-meow opened this issue 1 year ago • 20 comments

URL:

https://nodejs.org/

Browser Name:

Firefox

Browser Version:

123.0

Operating System:

Manjaro Linux 6.7.2

How to reproduce the issue:

  1. Using a Browser running under Linux, visit https://nodejs.org/en
  2. under "Download Node.js", click the left hand button that says "20.11.1 LTS"

Expected: tar.xz download Actual: Dead link, reporting a 404 nginx error

Additional info: It seems the link points to a x86 build, which does not exist. Specifically, it points to:
https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-x86.tar.xz While it should point to:
https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-x64.tar.xz

theo-meow avatar Feb 28 '24 16:02 theo-meow

nodejs

for reference

theo-meow avatar Feb 29 '24 08:02 theo-meow

I believe this is due to bitness detection in util/getNodeDownloadUrl.ts For whatever reason it detects an x86 build, even though I am on x64. In Issue nodejs/build#885, 32bit builds were dropped. My suggestion, though this is a dirty solution, would be to always link x64 builds for linux, since any other bitness can never be delivered.

theo-meow avatar Mar 01 '24 09:03 theo-meow

I believe this is due to bitness detection in util/getNodeDownloadUrl.ts For whatever reason it detects an x86 build, even though I am on x64. In Issue nodejs/build#885, 32bit builds were dropped. My suggestion, though this is a dirty solution, would be to always link x64 builds for linux, since any other bitness can never be delivered.

This issue only exists on the old/legacy Node.js website. Can you check if the same issue happens on the new website? (https://beta-node-js-org.vercel.app/en) (This website is not yet public)

ovflowd avatar Mar 02 '24 00:03 ovflowd

Hi @ovflowd , I have tried this and the issue does persist. This does not seem solved on the new site.

theo-meow avatar Mar 02 '24 19:03 theo-meow

Hi @ovflowd , I have tried this and the issue does persist. This does not seem solved on the new site.

We use the Browser Bitness API to get your system bitness. What browser do you use? You wrote 123.0 on Browser, is that a version or?

Note that it is only supported on these Browsers: https://developer.mozilla.org/en-US/docs/Web/API/NavigatorUAData/getHighEntropyValues

ovflowd avatar Mar 02 '24 19:03 ovflowd

As written in my initial message, my browser is Firefox 123.0 (version). On other websites that I tried, my browser bitness comes back as 32 bit too.

Whatever the case may be; I think since there are no x86 versions of nodejs for linux available, the website should not generate a download link that can never be valid.

theo-meow avatar Mar 02 '24 21:03 theo-meow

As written in my initial message, my browser is Firefox 123.0 (version).

I completely missed the name of the Browser!

And yes, this API is not available on Firefox.

Whatever the case may be; I think since there are no x64 versions of nodejs for linux available, the website should not generate a download link that can never be valid.

I'm unfortunately unable to reproduce your issue on the redesign. Could you mention in which tab you're facing this issue? The only tab supporting Linux on the redesign is the "Prebuilt Binaries" one, and we don't even show a x86 option for Linux there 🤔 could you record a screenshot/video of the issue on the redesig? i.e. https://beta-node-js-org.vercel.app

ovflowd avatar Mar 03 '24 00:03 ovflowd

In the prebuilt binaries I do not have this issue, However on the home page it looks like the page autodetects a linux x86, and generates a corresponding download link. I have reproduced this on 3 different devices, all running the latest KDE manjaro linux. So it's probably not something weird with my setup that's causing this.

Find a GIF attached.

nodejs

theo-meow avatar Mar 03 '24 16:03 theo-meow

In the prebuilt binaries I do not have this issue,

However on the home page it looks like the page autodetects a linux x86, and generates a corresponding download link.

I have reproduced this on 3 different devices, all running the latest KDE manjaro linux. So it's probably not something weird with my setup that's causing this.

Find a GIF attached.

nodejs

Right, but again, just to clarify the issue is not that it is detecting x86, it is just probably fall-backing to x86... But Ill work on a fix anyways

ovflowd avatar Mar 03 '24 16:03 ovflowd

by the by https://nodejs.org/en/download/prebuilt-binaries links to https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-64.tar.xz (note the 64 instead of x64)... which is also a 404. to bypass it you need to click to a different option then back (at which point it will select x64 properly)

image

Tested on FF 115 (Waterfox G6.0.9, which is built against FF ESR). Please respect the UNOFFICIAL DRAFT splashed all over https://wicg.github.io/ua-client-hints/#dom-navigatoruadata-gethighentropyvalues ...

o5k avatar Mar 19 '24 18:03 o5k

Screenshot Why the hell is this broken for 3 weeks (and counting)? FF has a 7.26% desktop browser market share

This issue has nothing to do with Firefox. It affects Firefox, but it's not related to Firefox.

ovflowd avatar Mar 19 '24 19:03 ovflowd

by the by nodejs.org/en/download/prebuilt-binaries links to https://nodejs.org/dist/v20.11.1/node-v20.11.1-linux-64.tar.xz (note the 64 instead of x64)... which is also a 404. to bypass it you need to click to a different option then back (at which point it will select x64 properly)

Oh that seems a typo from our side. @nodejs/nodejs-website can someone look into this?

ovflowd avatar Mar 19 '24 19:03 ovflowd

Screenshot Why the hell is this broken for 3 weeks (and counting)? FF has a 7.26% desktop browser market share

We did fix this issue, or at least we thought so that we did with the recently released redesign. Please mind your tone. We are all volunteers here.

ovflowd avatar Mar 19 '24 19:03 ovflowd

image

Using firefox version 123.0.1 and the issue still exists FYI. image

image

anandMohanan avatar Mar 19 '24 19:03 anandMohanan

Please mind your tone.

no fix your software

As mentioned before, we are working on a fix already, so there's no need for hostility.

ovflowd avatar Mar 19 '24 23:03 ovflowd

I'd appreciate it if y'all could test https://nodejs-org-git-fork-canerakdas-fix-linux-bitness-openjs.vercel.app/ this preview branch and check if the bug is fixed.

ovflowd avatar Mar 19 '24 23:03 ovflowd

Hi @ovflowd image image

Yes, I am able to download the file now using this branch https://nodejs-org-git-fork-canerakdas-fix-linux-bitness-openjs.vercel.app/ Have a Great day.

anandMohanan avatar Mar 20 '24 04:03 anandMohanan

I'd appreciate it if y'all could test https://nodejs-org-git-fork-canerakdas-fix-linux-bitness-openjs.vercel.app/ this preview branch and check if the bug is fixed.

Looks good to me, unable to reproduce the bug on this website.

theo-meow avatar Mar 20 '24 08:03 theo-meow