nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: broken ci badge on readme

Open asrvd opened this issue 2 years ago • 4 comments
trafficstars

there is no ci file named ci.yml inside the workflows folder, thus the badge wouldn't show. i replaced it with the github-pages.yml workflow

before:

image

after: image

asrvd avatar Mar 10 '23 09:03 asrvd

LGTM! 🚢

Thank you for your first contribution! It's a small change, but definitely appreciated!

yes, just wanted to start out with my first contribution to the repo, I'm planning on improving the site's UI as well, is there anything that needs to be done or I can just start making refactoring PRs?

asrvd avatar Mar 10 '23 12:03 asrvd

yes, just wanted to start out with my first contribution to the repo, I'm planning on improving the site's UI as well, is there anything that needs to be done or I can just start making refactoring PRs?

The aim now is to make this website look like https://nodejs.dev, I'm going to soon open a discussion thread to share what are the plans and how we think the work should be done.

Until then, feel free to get familiar with the other website :)

ovflowd avatar Mar 10 '23 13:03 ovflowd

yes, just wanted to start out with my first contribution to the repo, I'm planning on improving the site's UI as well, is there anything that needs to be done or I can just start making refactoring PRs?

The aim now is to make this website look like https://nodejs.dev, I'm going to soon open a discussion thread to share what are the plans and how we think the work should be done.

Until then, feel free to get familiar with the other website :)

I see, I'd love to be a take part in all of the work that's going to be put to do this, may I know if nodejs.dev is open sourced as well?

edit - found it already, ignore the above message please

asrvd avatar Mar 10 '23 14:03 asrvd

Yes. github.com/nodejs/nodejs.dev but just as a note that repository is going to be archived soon as we're going to focus on moving the layout/content from there to here.

ovflowd avatar Mar 10 '23 14:03 ovflowd