nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

About page link

Open AugustinMauroy opened this issue 3 years ago • 15 comments

Enter your suggestions in details:

In https://nodejs.org/en/about/ We have an link Blocking vs. Non-Blocking. so I propose to redirect to nodejs.dev

AugustinMauroy avatar Oct 12 '22 07:10 AugustinMauroy

We should remove the link from that guide. It is out of place there.

Trott avatar Oct 13 '22 02:10 Trott

We should remove the link from that guide. It is out of place there.

I propose more simply, that when you click or connect to about. We are redirected to https://nodejs.dev/en/about/

AugustinMauroy avatar Oct 13 '22 09:10 AugustinMauroy

We should remove the link from that guide. It is out of place there.

I propose more simply, that when you click or connect to about. We are redirected to https://nodejs.dev/en/about/

Why?

Trott avatar Oct 13 '22 13:10 Trott

instead of deleting we can redirect. This is less "direct".

AugustinMauroy avatar Oct 13 '22 14:10 AugustinMauroy

It doesn't make sense to redirect nodejs.org to nodejs.dev...

ovflowd avatar Oct 13 '22 14:10 ovflowd

@Trott @ovflowd @AugustinMauroy, can I take on the implementation of this issue...

HassanBahati avatar Oct 13 '22 15:10 HassanBahati

Depends? What do you want to do? I’m not sure there’s yet a clear decision of what should be done here

ovflowd avatar Oct 13 '22 15:10 ovflowd

Okay please, let me hold we until we arrive at a comprehensive way forward

HassanBahati avatar Oct 14 '22 07:10 HassanBahati

Okay please, let me hold we until we arrive at a comprehensive way forward

Sorry, no cookie-licking.

Trott avatar Oct 14 '22 19:10 Trott

Sorry, no cookie-licking.

If you'd like to get right to work, thoughl, I'd support both of these things:

  • Remove the About link from the bottom of https://nodejs.org/en/docs/guides/blocking-vs-non-blocking/ and all translations of that page.
  • Remove superfluous About content from the About page on nodejs.dev. It should at least be reduced to what we have on nodejs.org. All the stuff about cluster module and Twisted is outdated and/or out of place there. It should be removed.

Trott avatar Oct 14 '22 20:10 Trott

All the stuff about cluster module and Twisted is outdated and/or out of place there. It should be removed.

Could you pinpoint which paragraphs need to be removed from both places? 👀

ovflowd avatar Oct 14 '22 20:10 ovflowd

Could you pinpoint which paragraphs need to be removed from both places? 👀

Whoops, I thought we had already removed a bunch of that text from nodejs.org, but I am wrong wrong wrong. It's all still there.

So, OK, as a starter, this sentence should be rewritten or removed in my opinion:

Almost no function in Node.js directly performs I/O, so the process never blocks except when the I/O is performed using synchronous methods of Node.js standard library.

This seems superfluous to me:

Node.js is similar in design to, and influenced by, systems like Ruby's Event Machine and Python's Twisted. Node.js takes the event model a bit further.

But if it's removed, then "It" in the next sentence needs to be changed to "Node.js". And later material in the paragraph needs to be rewritten or removed because it refers back to the mention of Ruby in the first sentence, etc.

Some basic editing: Sometimes "event loop" has a hyphen in the text and sometimes not. (It should probably never have a hyphen in my opinion, except in some unusual cases.)

The whole page, from the sample code to the text, implies that Node.js is very HTTP-focused. There's some truth to that, but also, not really. So I wouldn't mind this paragraph being removed.

HTTP is a first-class citizen in Node.js, designed with streaming and low latency in mind. This makes Node.js well suited for the foundation of a web library or framework.

So that's my opinion based on just a few minutes of review. What do you think?

Trott avatar Oct 15 '22 00:10 Trott

Sorry, no cookie-licking.

If you'd like to get right to work, thoughl, I'd support both of these things:

  • Remove the About link from the bottom of https://nodejs.org/en/docs/guides/blocking-vs-non-blocking/ and all translations of that page.
  • Remove superfluous About content from the About page on nodejs.dev. It should at least be reduced to what we have on nodejs.org. All the stuff about cluster module and Twisted is outdated and/or out of place there. It should be removed.

@Trott am getting started right away on these tasks.

HassanBahati avatar Oct 15 '22 08:10 HassanBahati

Sorry, no cookie-licking.

If you'd like to get right to work, thoughl, I'd support both of these things:

  • Remove the About link from the bottom of https://nodejs.org/en/docs/guides/blocking-vs-non-blocking/ and all translations of that page.
  • Remove superfluous About content from the About page on nodejs.dev. It should at least be reduced to what we have on nodejs.org. All the stuff about cluster module and Twisted is outdated and/or out of place there. It should be removed.

@Trott am getting started right away on these tasks.

@Trott i have opened a pull request please review.

HassanBahati avatar Oct 15 '22 14:10 HassanBahati

@Trott @ovflowd do we need to remove the about link from bottom of https://nodejs.dev/en/learn/overview-of-blocking-vs-non-blocking/ on the website redesign similarly to how we have removed it from https://nodejs.org/en/docs/guides/blocking-vs-non-blocking/

HassanBahati avatar Oct 16 '22 21:10 HassanBahati

@HassanBahati I completely missed your comment, yes, we could remove it :)

ovflowd avatar Dec 31 '22 01:12 ovflowd

@HassanBahati I completely missed your comment, yes, we could remove it :)

here is a pr for it https://github.com/nodejs/nodejs.dev/pull/3110

HassanBahati avatar Dec 31 '22 08:12 HassanBahati