nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

GIthub does not render the too-long changelog of Nodejs 18.9.0

Open dilyanpalauzov opened this issue 3 years ago • 5 comments

URL:

https://nodejs.org/en/

Browser Name:

Irrelevant

Browser Version:

Irrelevant

Operation System:

Irrelevant

How to reproduce the issue:

At https://nodejs.org/en/ is written “Nodejs 18.9.0 Currenlt Changelog*. The Changelog is a hyperlink to https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.9.0 . Github does not render the final address, stating “This blob took too long to generate.

But you can view the raw file.”

dilyanpalauzov avatar Sep 12 '22 15:09 dilyanpalauzov

FYI @nodejs/releasers Don't think there is anything we can do with the github limitation though

nschonni avatar Sep 12 '22 16:09 nschonni

I think we'll need to change it to the GitHub changelog. Example: https://github.com/nodejs/node/releases/tag/v18.9.0

RafaelGSS avatar Sep 12 '22 16:09 RafaelGSS

I think we'll need to change it to the GitHub changelog. Example: https://github.com/nodejs/node/releases/tag/v18.9.0

There's another limitation on this. I had to truncate https://github.com/nodejs/node/releases/tag/v16.17.0 because the number of characters is limited.

targos avatar Sep 12 '22 16:09 targos

Wouldn't <details> solve it?

Commits
  • Full list of commits...

RafaelGSS avatar Sep 12 '22 16:09 RafaelGSS

No. There's at least a client-side check that just prevents from entering more characters: image

targos avatar Sep 12 '22 16:09 targos

As many mentioned before, this seems to be a GitHub limitation. Also this issue does not belong to this repository as the changelog is on nodejs/node.

Closing the issue.

ovflowd avatar Dec 30 '22 12:12 ovflowd