nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Published 20 hours ago • verified publisher icon nodejs

add a pr template

Open KendallDoesCoding opened this issue 3 years ago • 4 comments
trafficstars

Updated PR from #4299

KendallDoesCoding avatar Dec 28 '21 10:12 KendallDoesCoding

Please review and get back to me on this.

KendallDoesCoding avatar Feb 05 '22 08:02 KendallDoesCoding

The template content seems fine to me, however I just wonder whether we really need it or not? Because Nodejs.org isn't the same as Nodejs application. Waiting for others' suggestions.

SEWeiTung avatar Jul 30 '22 01:07 SEWeiTung

The template content seems fine to me, however I just wonder whether we really need it or not? Because Nodejs.org isn't the same as Nodejs application. Waiting for others' suggestions.

I kinda agree here in the standpoint of this node being the main Node repo. But it still feels like, a PR template might help first-time-contributors to follow a set of tasks.

A lot of people ignore the CONTRIBUTING.md files, so having some kind of text directly on their face, helps.

ovflowd avatar Aug 03 '22 07:08 ovflowd

I'm proceeding with the merge here 🙂 (Once the author rebases the branch)

ovflowd avatar Aug 15 '22 15:08 ovflowd

commented a few changes should this get merged.

bnb avatar Oct 10 '22 16:10 bnb

@aymen94 why'd you merge without addressing requested changes?

bnb avatar Oct 18 '22 16:10 bnb

This shouldn’t have been merged. @aymen94 could you please revert?

ovflowd avatar Oct 18 '22 17:10 ovflowd