nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Document the dependency on libbrotli in the online documentation

Open dilyanpalauzov opened this issue 5 years ago • 5 comments

NodeJS can be built with bundled libbrotly or with --shared-brotli.

Document the dependency on libbrotli at https://nodejs.org/en/docs/meta/topics/dependencies/ .

dilyanpalauzov avatar Jun 23 '20 08:06 dilyanpalauzov

@Trott why did you transfer the issue over here? That page is part of the docs in the node repo

nschonni avatar Jun 25 '20 02:06 nschonni

@Trott why did you transfer the issue over here? That page is part of the docs in the node repo

It's in this repo: https://github.com/nodejs/nodejs.org/blob/d0be2aeef14e089b5afbc0bceb6b7cf9bf578c46/locale/en/docs/meta/topics/dependencies.md

Trott avatar Jun 25 '20 02:06 Trott

👍 thanks, I was mixing up the api and docs folders

nschonni avatar Jun 25 '20 02:06 nschonni

There's actually quite a few dependencies we are missing there. I think we might want to just remove this.

Thoughts?

MylesBorins avatar Jun 25 '20 04:06 MylesBorins

There's actually quite a few dependencies we are missing there. I think we might want to just remove this.

Thoughts?

+1. It's hard to know what the purpose of this page is. None of these are dependencies you need to install to run Node.js. So this is more appropriately in the build docs in the main repo. And if we update it, it will just go out of date again.

Trott avatar Jun 26 '20 04:06 Trott

closing this. https://github.com/nodejs/nodejs.org/pull/5480 resolved the problem by linking to an up to date source over the the nodejs/node repo

bmuenzenmeyer avatar Jul 22 '23 20:07 bmuenzenmeyer