nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Remove source/schedule.json?

Open XhmikosR opened this issue 6 years ago • 4 comments

@Trott @rvagg since the deployment command always runs this, is there any reason for us to keep the file in the repository?

XhmikosR avatar Nov 12 '19 11:11 XhmikosR

I suppose not, but I'd defer to @rvagg on that for sure.

Trott avatar Nov 12 '19 14:11 Trott

sounds fine to me, I think it's always been redundant but maybe helpful for local installs/testing?

rvagg avatar Nov 13 '19 01:11 rvagg

Hmm true. If we remove it it will require to grab the schedule for local development. It's OK if it's documented, I guess.

We could even add it in a prestart script maybe?

XhmikosR avatar Nov 13 '19 07:11 XhmikosR

@Trott similarly I see source/versions.json is outdated because it's generated on build time too.

I made a patch for schedule.json, but perhaps we should tackle both?

XhmikosR avatar Nov 14 '19 16:11 XhmikosR

Closing as not relevant anymore. (File was removed already)

ovflowd avatar Mar 12 '23 13:03 ovflowd