nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

Remove English commented out code from translations

Open XhmikosR opened this issue 5 years ago • 8 comments

It seems it's common practice. We need another way for translators to follow the English files and know up to where they have translated. Maybe a simple HTML comment with the hash and then they can compare after that and see the diff.

Right now, many translations follow this practice which results in ~2x lines. All this does not come for free and it's bloating the codebase IMO.

Also, there's #2450.

XhmikosR avatar Sep 06 '19 06:09 XhmikosR

Hey! Can you tell me more about this issue?

grodd avatar Sep 15 '19 13:09 grodd

EX: English text is copied into the translated documents like

https://github.com/nodejs/nodejs.org/blame/347682b75702a51d515b307aabd1e4766df55978/locale/ko/about/index.md#L9-L18

So if the English is updated, these are actually out of sync.

nschonni avatar Sep 16 '19 01:09 nschonni

@XhmikosR and @nschonni, I know this so far, it seems this is Korean and Japanese's habit. So we don't need to worry about them. But in order to be fair, I'd invite @nodejs/nodejs-ko and @nodejs/nodejs-ja to have a discussion about it. If they don't agree with your ideas, I have to close your issue.

SEWeiTung avatar Sep 20 '19 02:09 SEWeiTung

Commenting the corresponding commit hash of English file may work. But transition will take time as it requires re-sync of all translation files. I personally don't have objections to having process transition. But I have to listen how @nodejs/nodejs-ko think.

yous avatar Sep 20 '19 02:09 yous

It's also a habit in pt_BR, at least in some files.

XhmikosR avatar Sep 20 '19 05:09 XhmikosR

We decided to go with CrowdIn approach here https://github.com/nodejs/i18n/issues/72 and I'm now working on configuring it, so this issue will be fixed in near future.

alexandrtovmach avatar Sep 20 '19 09:09 alexandrtovmach

@nschonni I haven't followed the translations on his repo so if this is sorted or if it will be sorted, feel free to close this issue.

XhmikosR avatar Feb 14 '21 18:02 XhmikosR

Crowdin is hooked up now, but it's not really used. Primarily the changes comes as PRs to the repo

nschonni avatar Feb 14 '21 18:02 nschonni

Closing this as the next.js migration removed the commented out english sources.

ovflowd avatar Mar 12 '23 13:03 ovflowd