nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

Update adding learn page.md

Open AugustinMauroy opened this issue 3 years ago • 3 comments

Update adding learn page.md

These modifications are there to avoid problems with the translation

AugustinMauroy avatar Sep 11 '22 14:09 AugustinMauroy

Codecov Report

Base: 66.02% // Head: 62.52% // Decreases project coverage by -3.49% :warning:

Coverage data is based on head (8653658) compared to base (fd57b87). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
- Coverage   66.02%   62.52%   -3.50%     
==========================================
  Files         118      124       +6     
  Lines        1351     1457     +106     
  Branches      342      361      +19     
==========================================
+ Hits          892      911      +19     
- Misses        422      505      +83     
- Partials       37       41       +4     
Impacted Files Coverage Δ
src/__fixtures__/page.tsx 94.11% <ø> (-5.89%) :arrow_down:
...components/ApiComponents/Components/ApiHeading.tsx 0.00% <ø> (ø)
...rc/components/ApiComponents/Components/ApiLink.tsx 0.00% <ø> (ø)
...ents/ApiComponents/Components/SourceLink/index.tsx 0.00% <ø> (ø)
...ApiComponents/Components/VersionSelector/index.tsx 0.00% <ø> (ø)
src/components/ApiComponents/index.tsx 0.00% <ø> (ø)
src/components/Article/index.tsx 100.00% <ø> (ø)
src/components/Banner/index.tsx 100.00% <ø> (ø)
src/components/Codebox/index.tsx 100.00% <ø> (ø)
src/components/EditLink/index.tsx 100.00% <ø> (ø)
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 11 '22 14:09 codecov-commenter

I'm not so sure we should ask them to delete the pages. It's "okay" to have translated versions a little bit outdated. Hence, we need to spot when they get updated and request translators to update them.

ovflowd avatar Sep 14 '22 08:09 ovflowd

@ovflowd Yes, but you still have to be careful. Because when we look at the knowledge base of nodejs.org, we see that the translations are very out of date.

AugustinMauroy avatar Sep 14 '22 19:09 AugustinMauroy