nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

Next button missing on the last page of each section on /learn

Open manishprivet opened this issue 1 year ago • 3 comments

URL:

https://nodejs.dev/en/learn/nodejs-the-difference-between-development-and-production/

Browser Name:

Microsoft Edge

Browser Version:

104.0.1293.70

Operating System:

MacOS 12.3

How to reproduce the issue:

  1. Go to the last page of any section on the /learn page, e.g., https://nodejs.dev/en/learn/nodejs-the-difference-between-development-and-production/
  2. Next button is missing from the end of the page while the expected behaviour is that it should be present there and take the user to the first page of the next section

manishprivet avatar Aug 28 '22 06:08 manishprivet

There is a "next" and "prev" option at the bottom of each page . One of them might be missing at times based on the page you are viewing. These options are present at the bottom most section of the page. (Present below "Edit this page on github")

Abhiram-Gullapalli avatar Aug 29 '22 14:08 Abhiram-Gullapalli

It is not present on the last page of each section because the value of the next prop is null which is responsible for the display of Pagination refer src/components/Pagination/index.tsx

Components for https://nodejs.dev/en/learn/the-nodejs-event-emitter/

image

Kunal0007 avatar Aug 29 '22 16:08 Kunal0007

This very likely happens within the createMarkdownPages.js utility.

ovflowd avatar Sep 04 '22 10:09 ovflowd

https://github.com/nodejs/nodejs.dev/pull/2796 makes this a nonissue since only one section exists

benhalverson avatar Sep 30 '22 01:09 benhalverson