nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard

Change the content of code examples

Open RomainLanz opened this issue 2 years ago • 7 comments

Hey there! 👋

Before making any PR, I would like to have a roundtable of the proposed changes.

Most of the code examples present inside the documentation are using ExpressJS. It is presented like anyone should know this framework, which feels wrong.

  1. This framework is outdated and should not be promoted nor presented in my opinion on the website.
  2. The goal of this website is to teach how to do things in Node.js directly and not by using a third-party library.

I would like to know if you would accept PRs that remove ExpressJS examples (in favor of Fastify when needed) and provide more bare Node.js examples.

RomainLanz avatar Jul 19 '21 12:07 RomainLanz

I found only 2 mentions of express in entire Learn section:

  • https://nodejs.dev/learn/how-to-exit-from-a-nodejs-program
  • https://nodejs.dev/learn/get-http-request-body-data-using-nodejs

Not sure that those 2 pages are contributing much in Express popularity and

It causes more harm than goods in the current Node.js ecosystem.

From my side - the end user is much more likely familiar with Express than other Node.js frameworks. What will be the benefit of updating those examples?

rodion-arr avatar Jul 21 '21 18:07 rodion-arr

Instead of promoting any Node.js frameworks, we should show examples using the core libs. Like replacing examples using express to examples using http. What do yall think?

Examples using third-party libs could be a in a different section to give some ideas on where to go or something

lancemccluskey avatar Jul 21 '21 18:07 lancemccluskey

+1 from my side to replace with core libs

rodion-arr avatar Jul 21 '21 21:07 rodion-arr

Did you want to work on this? @RomainLanz If not I can pick it up

lancemccluskey avatar Jul 22 '21 12:07 lancemccluskey

Did you want to work on this? @RomainLanz If not I can pick it up

Yes! I would be more than happy to provide few PRs to improve the current documentation.

RomainLanz avatar Jul 22 '21 14:07 RomainLanz

@lancemccluskey Any progress?

ephraimduncan avatar Oct 10 '21 13:10 ephraimduncan

Hey, @RomainLanz or @lancemccluskey are you folks still interested in contributing?

ovflowd avatar Aug 02 '22 21:08 ovflowd

Closing because this page is going away. https://github.com/nodejs/nodejs.dev/pull/2796

benhalverson avatar Sep 30 '22 01:09 benhalverson