nodejs.dev icon indicating copy to clipboard operation
nodejs.dev copied to clipboard
verified publisher icon nodejs

feat: i18n lang selector component

Open benhalverson opened this issue 4 years ago • 5 comments

Summary

Create a language selector component to allow the user to change the language text on nodejs.dev see https://nodejs.org language for supported languages (top right corner)

Motivation

Needed for i18n

benhalverson avatar Jul 14 '21 06:07 benhalverson

I would like to work on it.

smochan avatar Jul 14 '21 10:07 smochan

@smochan Can I take this task? I started code changes for some experimental purposes. Please let me know if that PR could use here if you are busy.

MrJithil avatar Aug 04 '21 19:08 MrJithil

No, I have already completed it. I just have to change its css a bit and I will make a PR till tomorrow.

smochan avatar Aug 05 '21 15:08 smochan

No, I have already completed it. I just have to change its css a bit and I will make a PR till tomorrow.

Okay. Thanks for the update.

CC: @benhalverson

MrJithil avatar Aug 05 '21 19:08 MrJithil

So the PR is ready, but we'll make a few changes before merging it. Such as:

  • [ ] First, getting the feature toggle issue done
  • [ ] Then add the disabled option for Languages that are not translated yet.
  • [ ] Remove all the json files for the disabled languages
  • [ ] Update the i18n manager to only include languages that are not disabled
  • [ ] Get the Markdown Issue done

ovflowd avatar Jul 27 '22 16:07 ovflowd