node icon indicating copy to clipboard operation
node copied to clipboard

deps: brotli: cherry-pick e230f474b87 fix LoongArch64 architecture build failed

Open Javonne-liu opened this issue 2 weeks ago • 1 comments

issue:#60835 LoongArch64 CI is in a failed state (https://ci.nodejs.org/job/node-test-commit-loongarch64/nodes=clfs23-64/852)

After upgrading Brotli to 1.2.0, the LoongArch64 architecture compilation fails with the error "invalid argument of ‘model’ attribute".

../deps/brotli/c/common/constants.h:196:23: error: invalid argument of ‘model’ attribute
  196 | BrotliPrefixCodeRange _kBrotliPrefixCodeRanges[BROTLI_NUM_BLOCK_LEN_SYMBOLS];
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~
../deps/brotli/c/common/constants.c:10:23: error: invalid argument of ‘model’ attribute
   10 | BrotliPrefixCodeRange _kBrotliPrefixCodeRanges[BROTLI_NUM_BLOCK_LEN_SYMBOLS] = {
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [deps/brotli/brotli.target.mk:122:/home/iojs/build/workspace/node-test-commit-loongarch64/out/Release/obj.target/brotli/deps/brotli/c/common/constants.o] 错误 1
make[2]: *** 正在等待未完成的任务....

Origin commit message:

disable BROTLI_MODEL macro for some targets

PiperOrigin-RevId: 827486322

Refs: https://github.com/google/brotli/commit/e230f474b87134e8c6c85b630084c612057f253e

Javonne-liu avatar Dec 09 '25 09:12 Javonne-liu

Review requested:

  • [ ] @nodejs/security-wg

nodejs-github-bot avatar Dec 09 '25 09:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70474/

nodejs-github-bot avatar Dec 10 '25 12:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70485/

nodejs-github-bot avatar Dec 10 '25 22:12 nodejs-github-bot

Landed in 180c71771414dd26d5be93682f16e47a1d168d23

nodejs-github-bot avatar Dec 11 '25 09:12 nodejs-github-bot