node
node copied to clipboard
nodejs
test_runner: propagate V8 options to child process
This PR should address #60986!
At the moment, this solution doesn't take into account NODE_OPTIONS nor the config file.
In order to support both of them, at least for V8 options defined as kV8Option, changes to GetOptionsAsFlags are required.
They will follow in a follow-up PR.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 88.53%. Comparing base (e28656a) to head (410174c).
:warning: Report is 6 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #60999 +/- ##
==========================================
+ Coverage 88.51% 88.53% +0.01%
==========================================
Files 703 703
Lines 208496 208512 +16
Branches 40213 40215 +2
==========================================
+ Hits 184555 184609 +54
+ Misses 15955 15948 -7
+ Partials 7986 7955 -31
| Files with missing lines | Coverage Δ | |
|---|---|---|
| lib/internal/test_runner/runner.js | 92.94% <100.00%> (+0.12%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Commit Queue failed
- Loading data for nodejs/node/pull/60999 ✔ Done loading data for nodejs/node/pull/60999 ----------------------------------- PR info ------------------------------------ Title test_runner: propagate V8 options to child process (#60999) Author Pietro Marchini <[email protected]> (@pmarchini) Branch pmarchini:issue-60986 -> nodejs:main Labels needs-ci, test_runner, lts-watch-v22.x, lts-watch-v24.x Commits 1 - test_runner: propagate V8 options to child process Committers 1 - Pietro Marchini <[email protected]> PR-URL: https://github.com/nodejs/node/pull/60999 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jacob Smith <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60999 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Jacob Smith <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 08 Dec 2025 23:35:59 GMT ✔ Approvals: 6 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/60999#pullrequestreview-3554808102 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/60999#pullrequestreview-3555539052 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556065594 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556879192 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60999#pullrequestreview-3556965246 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/60999#pullrequestreview-3559851497 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-12-09T12:33:04Z: https://ci.nodejs.org/job/node-test-pull-request/70446/ - Querying data for job/node-test-pull-request/70446/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/20116762228
