node icon indicating copy to clipboard operation
node copied to clipboard

[v24.x][riscv] V8 backport to resolve compile failure

Open sxa opened this issue 2 weeks ago • 17 comments

Failure referenced in https://github.com/nodejs/build/issues/4099#issuecomment-3617069521 - the single line fix to deps/v8/src/execution/riscv/simulator-riscv.h is enough to allow the cross-compiled build to pass but it seems cleaner to to pull the full commit across. If any reviewers disagree then I'm happy to cut this down to just the single line.

This will allow us to enable v24.x in the unofficial-builds repository.

sxa avatar Dec 08 '25 11:12 sxa

Review requested:

  • [ ] @nodejs/security-wg
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Dec 08 '25 11:12 nodejs-github-bot

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20026379622

github-actions[bot] avatar Dec 08 '25 11:12 github-actions[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70423/

nodejs-github-bot avatar Dec 08 '25 12:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70425/

nodejs-github-bot avatar Dec 08 '25 12:12 nodejs-github-bot

Failed to start CI
   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/20029272474

github-actions[bot] avatar Dec 08 '25 13:12 github-actions[bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6911/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6911/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6911/

nodejs-github-bot avatar Dec 08 '25 15:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70433/

nodejs-github-bot avatar Dec 08 '25 16:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70434/

nodejs-github-bot avatar Dec 08 '25 16:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6914/

nodejs-github-bot avatar Dec 08 '25 16:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6914/

nodejs-github-bot avatar Dec 08 '25 16:12 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6914/

nodejs-github-bot avatar Dec 08 '25 16:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70449/

nodejs-github-bot avatar Dec 09 '25 14:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70450/

nodejs-github-bot avatar Dec 09 '25 14:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70451/

nodejs-github-bot avatar Dec 09 '25 14:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70461/

nodejs-github-bot avatar Dec 09 '25 20:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70468/

nodejs-github-bot avatar Dec 10 '25 08:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70470/

nodejs-github-bot avatar Dec 10 '25 09:12 nodejs-github-bot

Landed in d4dceb93cb77.

richardlau avatar Dec 11 '25 13:12 richardlau