node icon indicating copy to clipboard operation
node copied to clipboard

test: enforce better never-settling-promise detection

Open aduh95 opened this issue 2 weeks ago • 2 comments

Tests should be explicit regarding whether a promise is expected to settle, and the test should fail when the behavior does not meet expectations.

aduh95 avatar Dec 06 '25 15:12 aduh95

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.53%. Comparing base (37d9cfc) to head (f510bd2). :warning: Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60976      +/-   ##
==========================================
+ Coverage   88.51%   88.53%   +0.02%     
==========================================
  Files         703      703              
  Lines      208430   208430              
  Branches    40198    40202       +4     
==========================================
+ Hits       184491   184540      +49     
+ Misses      15951    15897      -54     
- Partials     7988     7993       +5     

see 50 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 06 '25 16:12 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70404/

nodejs-github-bot avatar Dec 06 '25 17:12 nodejs-github-bot

Landed in e50cbc1abd41d4a47d60bfabd12cf72833096cbc

nodejs-github-bot avatar Dec 10 '25 23:12 nodejs-github-bot