node icon indicating copy to clipboard operation
node copied to clipboard

Remove redundancy in node.config schema keys for test and watch

Open aakashamy777 opened this issue 3 weeks ago • 5 comments

aakashamy777 avatar Dec 03 '25 11:12 aakashamy777

Review requested:

  • [ ] @nodejs/config

nodejs-github-bot avatar Dec 03 '25 11:12 nodejs-github-bot

okay i will go through the issue and guidelines again, will update the codebase

aakashamy777 avatar Dec 03 '25 18:12 aakashamy777

In addition of what Marco said, please add tests and PR description

IlyasShabi avatar Dec 03 '25 22:12 IlyasShabi

hey @marco-ippolito just refined the code... I have fixed the implementation to remove the redundant test- and watch- prefixes from keys inside their namespaces (not removing the namespaces themselves). can you check the updated codebase.

aakashamy777 avatar Dec 04 '25 18:12 aakashamy777

It doesnt look like it, the node.config.json is not updated

marco-ippolito avatar Dec 05 '25 07:12 marco-ippolito