[v25.x] deps: V8: cherry-pick 72b0e27bd936
Original commit message:
[regexp] Fix modifiers for ChoiceNodes
Each alternative might modify flags when their sub-graph is emitted.
We need to restore flags to the value at the beginning of a ChoiceNode
for each alternative.
Drive-by: Move regexp-modifiers test out of harmony/
Fixed: 447583670
Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/heads/main@{#102838}
Refs: https://github.com/v8/v8/commit/72b0e27bd936432d4998e4d1762e7a8fe6d347f5 Refs: https://github.com/nodejs/node/issues/60030
Review requested:
- [ ] @nodejs/gyp
- [ ] @nodejs/security-wg
- [ ] @nodejs/v8-update
CI: https://ci.nodejs.org/job/node-test-pull-request/70169/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6858/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6858/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6858/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6864/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6864/
You may need to rebase this to pick up https://github.com/nodejs/node/commit/5316b580ebfcbe5a60ef345a70e6d62762e5af0b to fix the V8 CI.
That answers that mystery 😄
CI: https://ci.nodejs.org/job/node-test-pull-request/70177/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6865/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6865/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6865/
CI: https://ci.nodejs.org/job/node-test-pull-request/70183/
CI: https://ci.nodejs.org/job/node-test-pull-request/70184/
How we can get this quite important fix 🩹 moving? 🙄
Landed in 8a3bd6e09aa4