node icon indicating copy to clipboard operation
node copied to clipboard

[v25.x] deps: V8: cherry-pick 72b0e27bd936

Open Renegade334 opened this issue 1 month ago • 16 comments

Original commit message:

[regexp] Fix modifiers for ChoiceNodes

Each alternative might modify flags when their sub-graph is emitted.
We need to restore flags to the value at the beginning of a ChoiceNode
for each alternative.

Drive-by: Move regexp-modifiers test out of harmony/

Fixed: 447583670
Change-Id: I9f41e51f34df7659461da0a4fcd28b7e157f52e1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6995181
Reviewed-by: Jakob Linke <[email protected]>
Commit-Queue: Patrick Thier <[email protected]>
Cr-Commit-Position: refs/heads/main@{#102838}

Refs: https://github.com/v8/v8/commit/72b0e27bd936432d4998e4d1762e7a8fe6d347f5 Refs: https://github.com/nodejs/node/issues/60030

Renegade334 avatar Nov 13 '25 16:11 Renegade334

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/security-wg
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Nov 13 '25 16:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70169/

nodejs-github-bot avatar Nov 14 '25 11:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6858/

nodejs-github-bot avatar Nov 14 '25 11:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6858/

nodejs-github-bot avatar Nov 14 '25 11:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6858/

nodejs-github-bot avatar Nov 14 '25 11:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6864/

nodejs-github-bot avatar Nov 14 '25 19:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6864/

nodejs-github-bot avatar Nov 14 '25 19:11 nodejs-github-bot

You may need to rebase this to pick up https://github.com/nodejs/node/commit/5316b580ebfcbe5a60ef345a70e6d62762e5af0b to fix the V8 CI.

richardlau avatar Nov 14 '25 19:11 richardlau

That answers that mystery 😄

Renegade334 avatar Nov 14 '25 19:11 Renegade334

CI: https://ci.nodejs.org/job/node-test-pull-request/70177/

nodejs-github-bot avatar Nov 15 '25 05:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6865/

nodejs-github-bot avatar Nov 15 '25 05:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6865/

nodejs-github-bot avatar Nov 15 '25 05:11 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6865/

nodejs-github-bot avatar Nov 15 '25 05:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70183/

nodejs-github-bot avatar Nov 15 '25 14:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/70184/

nodejs-github-bot avatar Nov 15 '25 16:11 nodejs-github-bot

How we can get this quite important fix 🩹 moving? 🙄

bricss avatar Dec 03 '25 23:12 bricss

Landed in 8a3bd6e09aa4

RafaelGSS avatar Dec 10 '25 13:12 RafaelGSS