node icon indicating copy to clipboard operation
node copied to clipboard

deps: update icu to 78.1

Open nodejs-github-bot opened this issue 1 month ago • 10 comments

This is an automated update of icu to 78.1.

nodejs-github-bot avatar Nov 01 '25 09:11 nodejs-github-bot

Review requested:

  • [ ] @nodejs/security-wg

nodejs-github-bot avatar Nov 01 '25 09:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/69987/

nodejs-github-bot avatar Nov 01 '25 10:11 nodejs-github-bot

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

targos avatar Nov 01 '25 13:11 targos

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 88.54%. Comparing base (7fd3688) to head (c5eb768). :warning: Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60523      +/-   ##
==========================================
- Coverage   88.56%   88.54%   -0.02%     
==========================================
  Files         703      703              
  Lines      208254   208239      -15     
  Branches    40156    40153       -3     
==========================================
- Hits       184430   184394      -36     
- Misses      15828    15866      +38     
+ Partials     7996     7979      -17     

see 63 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 01 '25 14:11 codecov[bot]

/cc @nodejs/i18n-api This output change is weird: https://ci.nodejs.org/job/node-test-commit-linuxone/nodes=rhel9-s390x/52175/testReport/junit/(root)/parallel/test_datetime_change_notify/

  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /Irish Standard Time|Greenwich Mean Time/. Input:

  '11/1/2025, 10:49:12 AM GMT+00:00'

FWIW it looks like a change when DST is not in effect (no longer outputs Greenwich Mean time):

> process.env.TZ='Europe/Dublin'
'Europe/Dublin'
> new Date('2025/10/01').toLocaleString('en-US', { timeZoneName: 'long' })
'10/1/2025, 12:00:00 AM Irish Standard Time'
> new Date('2025/11/01').toLocaleString('en-US', { timeZoneName: 'long' })
'11/1/2025, 12:00:00 AM GMT+00:00'
>

richardlau avatar Nov 03 '25 12:11 richardlau

/cc @srl295

The new output looks more like what we should get with timeZoneName: "longOffset"

targos avatar Nov 08 '25 09:11 targos

I pushed an update to the test, but still not convinced that it's an expected change.

targos avatar Nov 10 '25 11:11 targos

I pushed an update to the test, but still not convinced that it's an expected change.

Can you file a CLDR issue ?

srl295 avatar Nov 21 '25 21:11 srl295

CLDR bug: https://unicode-org.atlassian.net/browse/CLDR-19136

targos avatar Nov 27 '25 10:11 targos

CLDR bug: https://unicode-org.atlassian.net/browse/CLDR-19136

it's now an ICU bug, precipitated by a CLDR change.

srl295 avatar Nov 29 '25 23:11 srl295

https://unicode-org.atlassian.net/browse/ICU-23278

Let's wait for 78.2 or 79.1.

targos avatar Dec 14 '25 09:12 targos

https://unicode-org.atlassian.net/browse/ICU-23278

Let's wait for 78.2 or 79.1.

SGTM. FWIW https://github.com/unicode-org/icu/pull/3784 updates icu4c/source/data/misc/metaZones.txt which we don't check into the Node.js source tree so we'd have to regenerate deps/icu-small/source/data/in/icudt78l.dat.bz2 (i.e. we cannot use the floating patch method in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#floating-patches-to-icu).

Having said that, we do regenerate the dat file to pick up timezone updates (there's one coming (2025c) from https://github.com/unicode-org/icu-data/pull/46).

richardlau avatar Dec 19 '25 17:12 richardlau