node icon indicating copy to clipboard operation
node copied to clipboard

Add --max-heap-size option

Open tannal opened this issue 6 months ago • 2 comments

This PR fixs #58686

tannal avatar Jun 14 '25 23:06 tannal

Review requested:

  • [ ] @nodejs/config

nodejs-github-bot avatar Jun 14 '25 23:06 nodejs-github-bot

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 89.91%. Comparing base (5fe7800) to head (a57cee3). :warning: Report is 321 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58708      +/-   ##
==========================================
- Coverage   90.16%   89.91%   -0.26%     
==========================================
  Files         637      655      +18     
  Lines      188001   192830    +4829     
  Branches    36881    37791     +910     
==========================================
+ Hits       169509   173379    +3870     
- Misses      11238    12004     +766     
- Partials     7254     7447     +193     
Files with missing lines Coverage Δ
src/node_options.cc 84.71% <100.00%> (+0.26%) :arrow_up:

... and 211 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 15 '25 00:06 codecov[bot]

Hey @tannal, great job on putting together this PR 🚀

Just a quick heads-up: there's a specific process the project follows for making changes, including commit message formatting and code style guidelines. You can check it out here: https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#the-process-of-making-changes

Totally happy to help if you need a hand navigating any of it, feel free to reach out!

lluisemper avatar Aug 03 '25 20:08 lluisemper

@tannal Can I open a new PR to fix this issue?

haramj avatar Sep 21 '25 04:09 haramj

@tannal Can I open a new PR to fix this issue?

It's up to you. I don't think we need another pr.

tannal avatar Sep 22 '25 10:09 tannal