node icon indicating copy to clipboard operation
node copied to clipboard

process: move multipleResolves event to EOL

Open jasnell opened this issue 6 months ago β€’ 1 comments

The multipleResolves event has been deprecated for several years now. It's time.

jasnell avatar Jun 14 '25 21:06 jasnell

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.09%. Comparing base (eafbe27) to head (bb5a924). Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58707   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         640      640           
  Lines      188287   188225   -62     
  Branches    36917    36903   -14     
=======================================
- Hits       169628   169582   -46     
+ Misses      11361    11358    -3     
+ Partials     7298     7285   -13     
Files with missing lines Coverage Ξ”
lib/internal/process/promises.js 100.00% <100.00%> (ΓΈ)

... and 25 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 14 '25 22:06 codecov[bot]

@nodejs/tsc

jasnell avatar Jun 20 '25 20:06 jasnell

Commit Queue failed
- Loading data for nodejs/node/pull/58707
βœ”  Done loading data for nodejs/node/pull/58707
----------------------------------- PR info ------------------------------------
Title      process: move multipleResolves event to EOL (#58707)
Author     James M Snell <[email protected]> (@jasnell)
Branch     jasnell:jasnell/multipleresolves-eol -> nodejs:main
Labels     semver-major, process, deprecations, needs-ci, commit-queue-squash
Commits    2
 - process: move multipleResolves event to EOL
 - Apply suggestions from code review
Committers 2
 - James M Snell <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58707
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58707
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
--------------------------------------------------------------------------------
   β„Ή  This PR was created on Sat, 14 Jun 2025 21:50:54 GMT
   βœ”  Approvals: 3
   βœ”  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58707#pullrequestreview-2946874060
   βœ”  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58707#pullrequestreview-2947696086
   βœ”  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58707#pullrequestreview-2947784147
   ✘  Last GitHub CI failed
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   βœ”  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/15798026652

nodejs-github-bot avatar Jun 21 '25 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67594/

nodejs-github-bot avatar Jun 21 '25 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67596/

nodejs-github-bot avatar Jun 21 '25 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67598/

nodejs-github-bot avatar Jun 22 '25 02:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67599/

nodejs-github-bot avatar Jun 22 '25 02:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67632/

nodejs-github-bot avatar Jun 24 '25 03:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67653/

nodejs-github-bot avatar Jun 25 '25 16:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67708/ πŸ’›

nodejs-github-bot avatar Jun 28 '25 18:06 nodejs-github-bot

Landed in a3dfca90d1fa

jasnell avatar Jun 29 '25 11:06 jasnell