process: move multipleResolves event to EOL
The multipleResolves event has been deprecated for several years now. It's time.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.09%. Comparing base (
eafbe27) to head (bb5a924). Report is 52 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #58707 +/- ##
=======================================
Coverage 90.09% 90.09%
=======================================
Files 640 640
Lines 188287 188225 -62
Branches 36917 36903 -14
=======================================
- Hits 169628 169582 -46
+ Misses 11361 11358 -3
+ Partials 7298 7285 -13
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| lib/internal/process/promises.js | 100.00% <100.00%> (ΓΈ) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@nodejs/tsc
Commit Queue failed
- Loading data for nodejs/node/pull/58707 β Done loading data for nodejs/node/pull/58707 ----------------------------------- PR info ------------------------------------ Title process: move multipleResolves event to EOL (#58707) Author James M Snell <[email protected]> (@jasnell) Branch jasnell:jasnell/multipleresolves-eol -> nodejs:main Labels semver-major, process, deprecations, needs-ci, commit-queue-squash Commits 2 - process: move multipleResolves event to EOL - Apply suggestions from code review Committers 2 - James M Snell <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58707 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58707 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> -------------------------------------------------------------------------------- βΉ This PR was created on Sat, 14 Jun 2025 21:50:54 GMT β Approvals: 3 β - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58707#pullrequestreview-2946874060 β - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58707#pullrequestreview-2947696086 β - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58707#pullrequestreview-2947784147 β Last GitHub CI failed β No Jenkins CI runs detected -------------------------------------------------------------------------------- β Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15798026652
CI: https://ci.nodejs.org/job/node-test-pull-request/67594/
CI: https://ci.nodejs.org/job/node-test-pull-request/67596/
CI: https://ci.nodejs.org/job/node-test-pull-request/67598/
CI: https://ci.nodejs.org/job/node-test-pull-request/67599/
CI: https://ci.nodejs.org/job/node-test-pull-request/67632/
CI: https://ci.nodejs.org/job/node-test-pull-request/67653/
CI: https://ci.nodejs.org/job/node-test-pull-request/67708/ π
Landed in a3dfca90d1fa