node icon indicating copy to clipboard operation
node copied to clipboard

crypto: move deprecated hash and mgf1Hash options to EOL

Open jasnell opened this issue 6 months ago • 3 comments

Runtime deprecation for ~3 years.

jasnell avatar Jun 14 '25 21:06 jasnell

Review requested:

  • [ ] @nodejs/crypto

nodejs-github-bot avatar Jun 14 '25 21:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67447/

nodejs-github-bot avatar Jun 14 '25 21:06 nodejs-github-bot

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 90.14%. Comparing base (3f6ad56) to head (2eca463). Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/keygen.js 13.04% 18 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58706      +/-   ##
==========================================
- Coverage   90.15%   90.14%   -0.01%     
==========================================
  Files         637      637              
  Lines      188122   188121       -1     
  Branches    36886    36892       +6     
==========================================
- Hits       169595   169584      -11     
- Misses      11271    11278       +7     
- Partials     7256     7259       +3     
Files with missing lines Coverage Δ
lib/internal/crypto/keygen.js 92.59% <13.04%> (-5.44%) :arrow_down:

... and 24 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 14 '25 22:06 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67485/

nodejs-github-bot avatar Jun 16 '25 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67494/

nodejs-github-bot avatar Jun 17 '25 11:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67513/

nodejs-github-bot avatar Jun 18 '25 08:06 nodejs-github-bot

Landed in c3b986853c07

jasnell avatar Jun 20 '25 20:06 jasnell