nodejs
New SQlite database options
This introduces new SQLite database options that can be set at the database connection level.
cc @geeksilva97
Codecov Report
Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.
Project coverage is 90.11%. Comparing base (
5457443) to head (5693d3c). Report is 67 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/node_sqlite.cc | 92.00% | 0 Missing and 4 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #58697 +/- ##
==========================================
+ Coverage 90.03% 90.11% +0.07%
==========================================
Files 635 639 +4
Lines 187688 188262 +574
Branches 36761 36924 +163
==========================================
+ Hits 168991 169654 +663
+ Misses 11499 11326 -173
- Partials 7198 7282 +84
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node_sqlite.h | 83.67% <100.00%> (+15.67%) |
:arrow_up: |
| src/node_sqlite.cc | 81.06% <92.00%> (+0.26%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
~~Since it's addressing a TODO comment, you need to remove it from the code. I was unable to see it~~
I'm wrong
There are a few tests I think we don't need because they are redundant, e.g., those that handle the default scenario. Here, for example, the default is false already, which is already covered.
Other than that, I think you addressed the left comments as expected. Thank you.
I will just ping @nodejs/cpp-reviewers to get a more experienced C++ review.