fix: avoid false DEP0155 warning for "./*" exports on Windows (#58650)

Open vedant713 opened this issue 6 months ago • 2 comments

The logic for emitting the DEP0155 warning now checks that the export key is exactly "./" before displaying the warning.
Pattern mappings such as "./*" and valid subpath exports are no longer affected.

Fixes #58650

Jun 12 '25 00:06 vedant713

Review requested:

[ ] @nodejs/loaders

Jun 12 '25 00:06 nodejs-github-bot

Thanks! Could you please include a test-case so we can avoid a regression?

Jun 12 '25 06:06 JakobJingleheimer

@vedant713 Did you find time to add tests yet? This would be useful for the wider community and has been sitting here for a while now

Oct 29 '25 05:10 AcidRaZor

This is clearly not the right fix unfortunately. I will do some further investigation here.

Nov 01 '25 00:11 guybedford

I tried to replicate this today but was entirely unable to - https://github.com/nodejs/node/issues/58650#issuecomment-3505377589. If an updated replication is available please let me know.

Nov 07 '25 23:11 guybedford