node icon indicating copy to clipboard operation
node copied to clipboard

fs: move rmdir recursive option to end-of-life

Open jasnell opened this issue 6 months ago β€’ 8 comments

Has been runtime deprecated for ~ 5 years now. It's time.

jasnell avatar Jun 07 '25 14:06 jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/67313/ CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3603/

nodejs-github-bot avatar Jun 07 '25 14:06 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.16%. Comparing base (5fe7800) to head (5d2b775). Report is 33 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58616   +/-   ##
=======================================
  Coverage   90.16%   90.16%           
=======================================
  Files         637      637           
  Lines      188001   188081   +80     
  Branches    36881    36891   +10     
=======================================
+ Hits       169509   169584   +75     
- Misses      11238    11264   +26     
+ Partials     7254     7233   -21     
Files with missing lines Coverage Ξ”
lib/fs.js 98.16% <100.00%> (-0.02%) :arrow_down:
lib/internal/fs/promises.js 98.09% <100.00%> (ΓΈ)
lib/internal/fs/utils.js 99.68% <100.00%> (-0.01%) :arrow_down:

... and 38 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 07 '25 15:06 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67337/

nodejs-github-bot avatar Jun 08 '25 16:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67338/

nodejs-github-bot avatar Jun 08 '25 18:06 nodejs-github-bot

@nodejs/tsc please :-)

jasnell avatar Jun 13 '25 00:06 jasnell

CI: https://ci.nodejs.org/job/node-test-pull-request/67439/

nodejs-github-bot avatar Jun 14 '25 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67468/

nodejs-github-bot avatar Jun 15 '25 18:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67469/

nodejs-github-bot avatar Jun 15 '25 18:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67473/

nodejs-github-bot avatar Jun 16 '25 02:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67498/

nodejs-github-bot avatar Jun 17 '25 13:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67503/

nodejs-github-bot avatar Jun 17 '25 17:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67575/

nodejs-github-bot avatar Jun 20 '25 17:06 nodejs-github-bot

Landed in eec03020880cf83d20e827d9067bdbeb4e0adf64

nodejs-github-bot avatar Jun 21 '25 16:06 nodejs-github-bot