node icon indicating copy to clipboard operation
node copied to clipboard

doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js

Open pr4j3sh opened this issue 6 months ago • 3 comments

PR for #58572

Fixed definition of assert.ifError() in `lib/assert.js

pr4j3sh avatar Jun 04 '25 12:06 pr4j3sh

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.22%. Comparing base (1093f38) to head (d5eecae). Report is 150 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58573   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         635      635           
  Lines      187484   187494   +10     
  Branches    36842    36837    -5     
=======================================
+ Hits       169146   169158   +12     
+ Misses      11110    11108    -2     
  Partials     7228     7228           
Files with missing lines Coverage Δ
lib/assert.js 99.51% <100.00%> (ø)

... and 35 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 04 '25 14:06 codecov[bot]

Commit Queue failed
- Loading data for nodejs/node/pull/58573
✔  Done loading data for nodejs/node/pull/58573
----------------------------------- PR info ------------------------------------
Title      doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js (#58573)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     pr4j3sh:main -> nodejs:main
Labels     assert, author ready
Commits    1
 - doc: fix jsdoc definition of assert.ifError() fn in lib/assert.js
Committers 1
 - pr4j3sh <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58573
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58573
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 04 Jun 2025 12:36:54 GMT
   ✔  Approvals: 7
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58573#pullrequestreview-2896754404
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/58573#pullrequestreview-2896765115
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/58573#pullrequestreview-2897346481
   ✔  - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/58573#pullrequestreview-2897483081
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58573#pullrequestreview-2900419541
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/58573#pullrequestreview-2902131786
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/58573#pullrequestreview-2928434402
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/15653351751

nodejs-github-bot avatar Jun 14 '25 15:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67437/

nodejs-github-bot avatar Jun 14 '25 15:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67512/

nodejs-github-bot avatar Jun 18 '25 07:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67640/

nodejs-github-bot avatar Jun 24 '25 17:06 nodejs-github-bot

Landed in eaebfab2998e2ce9fedd51e8343df5d18aaebdcb

nodejs-github-bot avatar Jun 27 '25 13:06 nodejs-github-bot