node icon indicating copy to clipboard operation
node copied to clipboard

test: allow `tmpDir.path` to be modified

Open avivkeller opened this issue 7 months ago • 1 comments

The behavior was changed in 8e872999c446617ce2cd429aa230203d57082937, which broke make test-npm, as it tries modifying the path used for tmpDir.

avivkeller avatar May 05 '25 00:05 avivkeller

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.14%. Comparing base (f75a126) to head (2e2ad90). Report is 64 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58173      +/-   ##
==========================================
- Coverage   90.17%   90.14%   -0.03%     
==========================================
  Files         630      630              
  Lines      186756   186756              
  Branches    36664    36648      -16     
==========================================
- Hits       168399   168359      -40     
- Misses      11179    11183       +4     
- Partials     7178     7214      +36     

see 29 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 05 '25 01:05 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66624/

nodejs-github-bot avatar May 05 '25 20:05 nodejs-github-bot

This PR is author ready, no?

avivkeller avatar May 08 '25 19:05 avivkeller

CI: https://ci.nodejs.org/job/node-test-pull-request/66718/

nodejs-github-bot avatar May 08 '25 20:05 nodejs-github-bot

It's been seven days, can this land?

avivkeller avatar May 12 '25 18:05 avivkeller

Landed in 563be01292a84bc244a6e725b10b151bb7b7fab0

nodejs-github-bot avatar May 12 '25 18:05 nodejs-github-bot