node icon indicating copy to clipboard operation
node copied to clipboard

src: enable Float16Array and explicit resource management

Open targos opened this issue 8 months ago • 6 comments

These features are enabled in stable Chrome 136 but not in V8 by default.

targos avatar May 04 '25 09:05 targos

Review requested:

  • [ ] @nodejs/startup
  • [ ] @nodejs/web-standards

nodejs-github-bot avatar May 04 '25 09:05 nodejs-github-bot

@LiviaMedeiros this will allow a cleanup of the numerous --js-float16array flags added to the test suite recently.

panva avatar May 04 '25 10:05 panva

Thanks for the heads up, I'll do the cleanup if this lands.

LiviaMedeiros avatar May 04 '25 10:05 LiviaMedeiros

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (995ad2b) to head (f75a126). Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58154      +/-   ##
==========================================
+ Coverage   90.14%   90.17%   +0.02%     
==========================================
  Files         630      630              
  Lines      186754   186756       +2     
  Branches    36648    36664      +16     
==========================================
+ Hits       168347   168399      +52     
+ Misses      11186    11179       -7     
+ Partials     7221     7178      -43     
Files with missing lines Coverage Δ
src/node.cc 73.35% <100.00%> (+0.07%) :arrow_up:

... and 29 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 04 '25 10:05 codecov[bot]

That’s semver-major given that it adds a global, it would be good to have it on 24.0.0 although we’re way past the cutoff

aduh95 avatar May 04 '25 11:05 aduh95

@nodejs/tsc I think we should land this in v24.

mcollina avatar May 04 '25 13:05 mcollina

CI: https://ci.nodejs.org/job/node-test-pull-request/66584/

nodejs-github-bot avatar May 04 '25 16:05 nodejs-github-bot

Fast-track has been requested by @aduh95. Please 👍 to approve.

github-actions[bot] avatar May 04 '25 16:05 github-actions[bot]

Would splitting this into two PRs or landing as two separate commits make more sense, since it enables two independent/unrelated to each other features at once?

LiviaMedeiros avatar May 04 '25 17:05 LiviaMedeiros

CI: https://ci.nodejs.org/job/node-test-pull-request/66591/

nodejs-github-bot avatar May 04 '25 17:05 nodejs-github-bot

Landed in 5ac126bbe655...f75a1265a8eef5c2058be1fde6eefa4ca0b5990f

aduh95 avatar May 04 '25 23:05 aduh95