src: enable Float16Array and explicit resource management
These features are enabled in stable Chrome 136 but not in V8 by default.
Review requested:
- [ ] @nodejs/startup
- [ ] @nodejs/web-standards
@LiviaMedeiros this will allow a cleanup of the numerous --js-float16array flags added to the test suite recently.
Thanks for the heads up, I'll do the cleanup if this lands.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.17%. Comparing base (
995ad2b) to head (f75a126). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #58154 +/- ##
==========================================
+ Coverage 90.14% 90.17% +0.02%
==========================================
Files 630 630
Lines 186754 186756 +2
Branches 36648 36664 +16
==========================================
+ Hits 168347 168399 +52
+ Misses 11186 11179 -7
+ Partials 7221 7178 -43
| Files with missing lines | Coverage Δ | |
|---|---|---|
| src/node.cc | 73.35% <100.00%> (+0.07%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
That’s semver-major given that it adds a global, it would be good to have it on 24.0.0 although we’re way past the cutoff
@nodejs/tsc I think we should land this in v24.
CI: https://ci.nodejs.org/job/node-test-pull-request/66584/
Fast-track has been requested by @aduh95. Please 👍 to approve.
Would splitting this into two PRs or landing as two separate commits make more sense, since it enables two independent/unrelated to each other features at once?
CI: https://ci.nodejs.org/job/node-test-pull-request/66591/
Landed in 5ac126bbe655...f75a1265a8eef5c2058be1fde6eefa4ca0b5990f