node icon indicating copy to clipboard operation
node copied to clipboard

async_hooks: ensure AsyncLocalStore instances work isolated

Open Flarna opened this issue 7 months ago β€’ 1 comments

Avoid that one AsyncLocalStore instance changes the state of another AsyncLocalStore instance by restoring only the owned store instead the complete AsyncContextFrame.

Flarna avatar May 03 '25 22:05 Flarna

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (92102c0) to head (7f4ed98). Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58149      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         630      630              
  Lines      186473   186507      +34     
  Branches    36612    36618       +6     
==========================================
+ Hits       168169   168183      +14     
- Misses      11116    11121       +5     
- Partials     7188     7203      +15     
Files with missing lines Coverage Ξ”
...nternal/async_local_storage/async_context_frame.js 100.00% <100.00%> (ΓΈ)

... and 32 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 03 '25 23:05 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66614/

nodejs-github-bot avatar May 05 '25 15:05 nodejs-github-bot

Landed in a0d458e448fb3e356fd7f657e9929b1d879860e3

nodejs-github-bot avatar May 06 '25 18:05 nodejs-github-bot