node icon indicating copy to clipboard operation
node copied to clipboard

esm: add support for dynamic source phase hook

Open guybedford opened this issue 7 months ago • 3 comments

This adds the support for the dynamic import.source() phase from the latest V8, and enabling the tests.

//cc @nodejs/loaders

guybedford avatar May 03 '25 19:05 guybedford

Review requested:

  • [ ] @nodejs/loaders
  • [ ] @nodejs/vm

nodejs-github-bot avatar May 03 '25 19:05 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.21%. Comparing base (53944c4) to head (7ca049e). Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58147   +/-   ##
=======================================
  Coverage   90.21%   90.21%           
=======================================
  Files         635      635           
  Lines      187171   187172    +1     
  Branches    36748    36754    +6     
=======================================
+ Hits       168851   168852    +1     
- Misses      11069    11079   +10     
+ Partials     7251     7241   -10     
Files with missing lines Coverage Δ
src/module_wrap.cc 72.52% <100.00%> (+0.39%) :arrow_up:

... and 39 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 03 '25 20:05 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66574/

nodejs-github-bot avatar May 03 '25 23:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66663/

nodejs-github-bot avatar May 07 '25 00:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66757/

nodejs-github-bot avatar May 11 '25 14:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66995/

nodejs-github-bot avatar May 22 '25 02:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66996/

nodejs-github-bot avatar May 22 '25 02:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67000/

nodejs-github-bot avatar May 22 '25 06:05 nodejs-github-bot

Landed in https://github.com/nodejs/node/commit/f5ac35ee156481088136fa39a4ceffe59850c326.

guybedford avatar May 22 '25 14:05 guybedford