node icon indicating copy to clipboard operation
node copied to clipboard

deps: update llhttp to 9.3.0

Open indutny opened this issue 6 months ago • 3 comments

[email protected] optimizes header value parsing on ARM Neon/WASM, and adds support for a protocol callback for use outside of the typical HTTP setting (RTSP/ICE).

indutny avatar May 03 '25 17:05 indutny

Review requested:

  • [ ] @nodejs/http
  • [ ] @nodejs/net
  • [ ] @nodejs/security-wg

nodejs-github-bot avatar May 03 '25 17:05 nodejs-github-bot

cc @nodejs/http @nodejs/llhttp

indutny avatar May 03 '25 17:05 indutny

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.17%. Comparing base (723d7bb) to head (d41e8cb). Report is 317 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58144      +/-   ##
==========================================
- Coverage   90.17%   90.17%   -0.01%     
==========================================
  Files         630      630              
  Lines      186473   186473              
  Branches    36613    36614       +1     
==========================================
- Hits       168160   168151       -9     
+ Misses      11128    11121       -7     
- Partials     7185     7201      +16     
Files with missing lines Coverage Δ
src/node_http_parser.cc 83.02% <ø> (ø)

... and 27 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 03 '25 19:05 codecov[bot]

Marked as dont-land-on-v20.x because it has llhttp v8.

mcollina avatar May 05 '25 07:05 mcollina

Commit Queue failed
- Loading data for nodejs/node/pull/58144
✔  Done loading data for nodejs/node/pull/58144
----------------------------------- PR info ------------------------------------
Title      deps: update llhttp to 9.3.0 (#58144)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     indutny:feature/llhttp-9-3-0 -> nodejs:main
Labels     lib / src, needs-ci, dont-land-on-v20.x
Commits    1
 - deps: update llhttp to 9.3.0
Committers 1
 - Fedor Indutny <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58144
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 03 May 2025 17:49:33 GMT
   ✔  Approvals: 4
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813280324
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813281787
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813479866
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58144#pullrequestreview-2813582968
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14842769407

nodejs-github-bot avatar May 05 '25 17:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66636/

nodejs-github-bot avatar May 06 '25 06:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66646/

nodejs-github-bot avatar May 06 '25 13:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66658/

nodejs-github-bot avatar May 06 '25 20:05 nodejs-github-bot

Landed in 4454d09e8f7225ec1b576ef86c8705bca63a136c

nodejs-github-bot avatar May 07 '25 14:05 nodejs-github-bot