node icon indicating copy to clipboard operation
node copied to clipboard

http: remove unused functions and add todos

Open anonrig opened this issue 7 months ago β€’ 4 comments

I've added TODOs to all functions that can be added a v8 fast api.

anonrig avatar May 03 '25 16:05 anonrig

Review requested:

  • [ ] @nodejs/http
  • [ ] @nodejs/net

nodejs-github-bot avatar May 03 '25 16:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66569/

nodejs-github-bot avatar May 03 '25 17:05 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.18%. Comparing base (723d7bb) to head (12b0a63). Report is 53 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58143   +/-   ##
=======================================
  Coverage   90.17%   90.18%           
=======================================
  Files         630      630           
  Lines      186473   186457   -16     
  Branches    36613    36609    -4     
=======================================
- Hits       168160   168159    -1     
+ Misses      11128    11117   -11     
+ Partials     7185     7181    -4     
Files with missing lines Coverage Ξ”
src/node_http_parser.cc 84.26% <ΓΈ> (+1.23%) :arrow_up:

... and 24 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 03 '25 17:05 codecov[bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66597/

nodejs-github-bot avatar May 04 '25 19:05 nodejs-github-bot

Do you have a link on how eventually is supposed to be done?

I haven't created any issue. I'm planning on adding them soon.

anonrig avatar May 05 '25 16:05 anonrig

CI: https://ci.nodejs.org/job/node-test-pull-request/66618/

nodejs-github-bot avatar May 05 '25 16:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66626/

nodejs-github-bot avatar May 05 '25 21:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66634/

nodejs-github-bot avatar May 06 '25 03:05 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/66665/

nodejs-github-bot avatar May 07 '25 01:05 nodejs-github-bot

Landed in e46fb17ecbd79968d6523a9517916976eca5dce6

nodejs-github-bot avatar May 09 '25 02:05 nodejs-github-bot