http: remove unused functions and add todos
I've added TODOs to all functions that can be added a v8 fast api.
Review requested:
- [ ] @nodejs/http
- [ ] @nodejs/net
CI: https://ci.nodejs.org/job/node-test-pull-request/66569/
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.18%. Comparing base (
723d7bb) to head (12b0a63). Report is 53 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #58143 +/- ##
=======================================
Coverage 90.17% 90.18%
=======================================
Files 630 630
Lines 186473 186457 -16
Branches 36613 36609 -4
=======================================
- Hits 168160 168159 -1
+ Misses 11128 11117 -11
+ Partials 7185 7181 -4
| Files with missing lines | Coverage Ξ | |
|---|---|---|
| src/node_http_parser.cc | 84.26% <ΓΈ> (+1.23%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
CI: https://ci.nodejs.org/job/node-test-pull-request/66597/
Do you have a link on how eventually is supposed to be done?
I haven't created any issue. I'm planning on adding them soon.
CI: https://ci.nodejs.org/job/node-test-pull-request/66618/
CI: https://ci.nodejs.org/job/node-test-pull-request/66626/
CI: https://ci.nodejs.org/job/node-test-pull-request/66634/
CI: https://ci.nodejs.org/job/node-test-pull-request/66665/
Landed in e46fb17ecbd79968d6523a9517916976eca5dce6